Yair Zaslavsky has posted comments on this change.

Change subject: core: Changes type of VmDevice from String to enum
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
Line 103:               <include name="common/businessentities/VM.java" />
Line 104:               <include name="common/businessentities/VmPayload.java" 
/>
Line 105:               <include name="common/businessentities/VmBase.java" />
Line 106:               <include name="common/businessentities/VmDynamic.java" 
/>
Line 107:         <include name="common/businessentities/VmDevice.java" />
Tabulation problem, please fix.
Line 108:               <include 
name="common/businessentities/VmDeviceGeneralType.java" />
Line 109:               <include name="common/businessentities/VmDeviceId.java" 
/>
Line 110:               <include 
name="common/businessentities/VmExitStatus.java" />
Line 111:               <include name="common/businessentities/VmOsType.java" />


--
To view, visit http://gerrit.ovirt.org/14812
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icada39e3918fb053cb0ad0388178ccf5c6338ca2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to