Oved Ourfali has posted comments on this change.

Change subject: findbugs: ignore: Boolean return value should not return null
......................................................................


Patch Set 1: Looks good to me, approved

(1 inline comment)

fix typo and shoot

....................................................
File frontend/webadmin/modules/webadmin/pom.xml
Line 303:             <artifactId>findbugs-maven-plugin</artifactId>
Line 304:             <version>${findbugs.version}</version>
Line 305:             <configuration>
Line 306:               <xmlOutput>true</xmlOutput>
Line 307:               <!-- Optional derectory to put findbugs xdoc xml report 
-->
fix typo
Line 308:               
<excludeFilterFile>exclude-filters.xml</excludeFilterFile>
Line 309:               <xmlOutputDirectory>target/site</xmlOutputDirectory>
Line 310:             </configuration>
Line 311:          </plugin>


--
To view, visit http://gerrit.ovirt.org/14682
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f16b1b5941aadcb2c7488500ce63eb2bf57436
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to