Shahar Havivi has uploaded a new change for review.

Change subject: findbugs: ignore: Boolean return value should not return null
......................................................................

findbugs: ignore: Boolean return value should not return null

Change-Id: I90f16b1b5941aadcb2c7488500ce63eb2bf57436
Signed-off-by: Shahar Havivi <[email protected]>
---
A frontend/webadmin/modules/webadmin/exclude-filters.xml
M frontend/webadmin/modules/webadmin/pom.xml
2 files changed, 41 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/82/14682/1

diff --git a/frontend/webadmin/modules/webadmin/exclude-filters.xml 
b/frontend/webadmin/modules/webadmin/exclude-filters.xml
new file mode 100644
index 0000000..0222367
--- /dev/null
+++ b/frontend/webadmin/modules/webadmin/exclude-filters.xml
@@ -0,0 +1,7 @@
+<FindBugsFilter>
+    <Match>
+        <Class 
name="org.ovirt.engine.ui.webadmin.plugin.jsni.JsFunctionResultHelper" />
+        <Method name="getResultAsBoolean"/>
+        <Bug code="NP"/>
+    </Match>
+</FindBugsFilter>
diff --git a/frontend/webadmin/modules/webadmin/pom.xml 
b/frontend/webadmin/modules/webadmin/pom.xml
index 8da1a29..728bdc1 100644
--- a/frontend/webadmin/modules/webadmin/pom.xml
+++ b/frontend/webadmin/modules/webadmin/pom.xml
@@ -196,6 +196,18 @@
           <propertyExpansion>runNlsCheck=true</propertyExpansion>
         </configuration>
       </plugin>
+         <plugin>
+            <groupId>org.codehaus.mojo</groupId>
+            <artifactId>findbugs-maven-plugin</artifactId>
+            <version>${findbugs.version}</version>
+            <configuration>
+              <xmlOutput>true</xmlOutput>
+              <!-- Optional derectory to put findbugs xdoc xml report -->
+              <excludeFilterFile>exclude-filters.xml</excludeFilterFile>
+              <xmlOutputDirectory>target/site</xmlOutputDirectory>
+            </configuration>
+         </plugin>
+
     </plugins>
   </build>
   <profiles>
@@ -219,6 +231,17 @@
               </execution>
             </executions>
           </plugin>
+         <plugin>
+            <groupId>org.codehaus.mojo</groupId>
+            <artifactId>findbugs-maven-plugin</artifactId>
+            <version>${findbugs.version}</version>
+            <configuration>
+              <xmlOutput>true</xmlOutput>
+              <!-- Optional derectory to put findbugs xdoc xml report -->
+              <excludeFilterFile>exclude-filters.xml</excludeFilterFile>
+              <xmlOutputDirectory>target/site</xmlOutputDirectory>
+            </configuration>
+         </plugin>
         </plugins>
       </build>
     </profile>
@@ -275,6 +298,17 @@
               </execution>
             </executions>
           </plugin>
+         <plugin>
+            <groupId>org.codehaus.mojo</groupId>
+            <artifactId>findbugs-maven-plugin</artifactId>
+            <version>${findbugs.version}</version>
+            <configuration>
+              <xmlOutput>true</xmlOutput>
+              <!-- Optional derectory to put findbugs xdoc xml report -->
+              <excludeFilterFile>exclude-filters.xml</excludeFilterFile>
+              <xmlOutputDirectory>target/site</xmlOutputDirectory>
+            </configuration>
+         </plugin>
         </plugins>
       </build>
     </profile>


--
To view, visit http://gerrit.ovirt.org/14682
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I90f16b1b5941aadcb2c7488500ce63eb2bf57436
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to