Oved Ourfali has posted comments on this change.
Change subject: foreman integration - showing foreman hosts in new host dialog
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
Line 144: }
Line 145:
Line 146: private ListModel privateHostName;
Line 147:
Line 148: public ListModel getHostName()
you're right. will fix that.
Line 149: {
Line 150: return privateHostName;
Line 151: }
Line 152:
Line 1067:
Line 1068: ArrayList<VDS> hosts = (ArrayList<VDS>) result;
Line 1069: ListModel hostNameListModel =
hostListModel.getHostName();
Line 1070: hostNameListModel.setItems(hosts);
Line 1071: hostNameListModel.setSelectedItem(null);
I saw that my setting it as the selected item it was also shown as an item in
the UI.
Line 1072: hostNameListModel.setIsSelectable(true);
Line 1073: hostNameListModel.setIsChangable(true);
Line 1074: hostNameListModel.setIsEmpty(false);
Line 1075: getName().setEntity("");
Line 1118: public void OnSuccess(Object model, Object
returnValue) {
Line 1119:
Line 1120: List<String> pmOptions = (ArrayList<String>)
returnValue;
Line 1121:
Line 1122: if (pmOptions != null) {
It isn't.
Saw a problem in that while testing my patch.
Will move it to another patch.
Line 1123:
getPmPort().setIsAvailable(pmOptions.contains(PmPortKey));
Line 1124:
getPmSlot().setIsAvailable(pmOptions.contains(PmSlotKey));
Line 1125:
getPmSecure().setIsAvailable(pmOptions.contains(PmSecureKey));
Line 1126: }
--
To view, visit http://gerrit.ovirt.org/14582
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30ea180e477a8f0714c4dc97ec55f29be515723a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
