Yair Zaslavsky has posted comments on this change.
Change subject: foreman integration - showing foreman hosts in new host dialog
......................................................................
Patch Set 2: (3 inline comments)
I would also advise to add [WIP] at commit msg.
Thanks!
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetHostListFromExternalProviderQuery.java
Line 5: import org.ovirt.engine.core.common.config.Config;
Line 6: import org.ovirt.engine.core.common.config.ConfigValues;
Line 7: import
org.ovirt.engine.core.common.queries.GetHostListFromExternalProviderParameters;
Line 8:
Line 9: public class GetHostListFromExternalProviderQuery<P extends
GetHostListFromExternalProviderParameters> extends QueriesCommandBase<P> {
Please provide test class for the query
Line 10: public GetHostListFromExternalProviderQuery(P parameters) {
Line 11: super(parameters);
Line 12: }
Line 13:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHost.java
Line 1: package org.ovirt.engine.core.bll.host.provider.foreman;
Line 2:
Line 3: import org.codehaus.jackson.map.annotate.JsonRootName;
Line 4:
Line 5: @JsonRootName("host")
UI should not be exposed to these entities?
They do look like business entities (as they are simple java beans), but in bll.
Just making sure
Line 6: public class ForemanHost {
Line 7:
Line 8: private String name;
Line 9:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostList.java
Line 3: public class ForemanHostList {
Line 4:
Line 5: private ForemanHost[] hosts;
Line 6:
Line 7: public ForemanHost[] getHosts() {
Why array and not collection?
Line 8: return hosts;
Line 9: }
Line 10:
Line 11: public void setHosts(ForemanHost[] hosts) {
--
To view, visit http://gerrit.ovirt.org/14582
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30ea180e477a8f0714c4dc97ec55f29be515723a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
