Kanagaraj M has posted comments on this change.

Change subject: engine: fetch gluster host uuid during InitVdsOnUp
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 343:                     }
Line 344:                 } catch (UnknownHostException e) {
Line 345:                     log.errorFormat("Could not resole IP address of 
the host {0}. Error: {1}",
Line 346:                             glusterServer.getHostnameOrIp(),
Line 347:                             e.getMessage());
we are fetching the peer list(host list) from one of the UP servers of the 
cluster. Then take each host and resolve their ip address. Compare the ip 
address of the each of the host with the current server we are processing. 

There can be a case where we may not be able to resole the ip address of 
one/more hosts of the cluster. So we just skip that host and move to next one 
to compare. There is no need to move this current server to NON_OPERATIONAL if 
there is a failure in resolving to IP.
Line 348:                 }
Line 349:             }
Line 350:         }
Line 351:         return false;


--
To view, visit http://gerrit.ovirt.org/14166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied8e8b006adc5722cd70ee19d75a4b6f783d5f44
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to