Gilad Chaplik has posted comments on this change.

Change subject: userportal,webadmin: implement VM builder
......................................................................


Patch Set 11: (6 inline comments)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/CommonUnitToVmBuilder.java
Line 12: 
Line 13: /**
Line 14:  * Misc fields common for all who need to build the VM <-> UnitVmModel
Line 15:  */
Line 16: public class CommonUnitToVmBuilder extends 
BaseSyncBuilder<UnitVmModel, VM> {
no matching builder
Line 17: 
Line 18:     @SuppressWarnings("unchecked")
Line 19:     @Override
Line 20:     protected void build(UnitVmModel frontend, VM backend) {


....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/IdVmToVmBuilder.java
Line 2: 
Line 3: import org.ovirt.engine.core.common.businessentities.VM;
Line 4: import org.ovirt.engine.ui.uicommonweb.builders.BaseSyncBuilder;
Line 5: 
Line 6: public class IdVmToVmBuilder extends BaseSyncBuilder<VM, VM> {
no matching builder
Line 7: 
Line 8:     @Override
Line 9:     protected void build(VM source, VM destination) {
Line 10:         destination.setId(source.getId());        


....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/MigrationSupportVmToUnitBuilder.java
Line 3: import org.ovirt.engine.core.common.businessentities.VM;
Line 4: import org.ovirt.engine.ui.uicommonweb.builders.BaseSyncBuilder;
Line 5: import org.ovirt.engine.ui.uicommonweb.models.vms.UnitVmModel;
Line 6: 
Line 7: public class MigrationSupportVmToUnitBuilder extends 
BaseSyncBuilder<UnitVmModel, VM> {
no matching builder
Line 8: 
Line 9:     @Override
Line 10:     protected void build(UnitVmModel frontend, VM backend) {
Line 11:         backend.setCpuPinning((String) 
frontend.getCpuPinning().getEntity());


....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/QuotaUnitToVmBuilder.java
Line 4: import org.ovirt.engine.core.common.businessentities.VM;
Line 5: import org.ovirt.engine.ui.uicommonweb.builders.BaseSyncBuilder;
Line 6: import org.ovirt.engine.ui.uicommonweb.models.vms.UnitVmModel;
Line 7: 
Line 8: public class QuotaUnitToVmBuilder extends BaseSyncBuilder<UnitVmModel, 
VM> {
no matching builder
Line 9: 
Line 10:     @Override
Line 11:     protected void build(UnitVmModel source, VM destination) {
Line 12:         if (source.getQuota().getSelectedItem() != null) {


....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/UsbPolicyUntiToVmBuilder.java
Line 4: import org.ovirt.engine.core.common.businessentities.VM;
Line 5: import org.ovirt.engine.ui.uicommonweb.builders.BaseSyncBuilder;
Line 6: import org.ovirt.engine.ui.uicommonweb.models.vms.UnitVmModel;
Line 7: 
Line 8: public class UsbPolicyUntiToVmBuilder extends 
BaseSyncBuilder<UnitVmModel, VM> {
/s/unti/unit
Line 9: 
Line 10:     @Override
Line 11:     protected void build(UnitVmModel frontend, VM backend) {
Line 12:         backend.setUsbPolicy((UsbPolicy) 
frontend.getUsbPolicy().getSelectedItem());


....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/VmSpecificUnitToVmBuilder.java
Line 4: import org.ovirt.engine.core.common.businessentities.VmTemplate;
Line 5: import org.ovirt.engine.ui.uicommonweb.builders.BaseSyncBuilder;
Line 6: import org.ovirt.engine.ui.uicommonweb.models.vms.UnitVmModel;
Line 7: 
Line 8: public class VmSpecificUnitToVmBuilder extends 
BaseSyncBuilder<UnitVmModel, VM> {
no matching builder
Line 9: 
Line 10:     @Override
Line 11:     protected void build(UnitVmModel frontend, VM backend) {
Line 12: 


--
To view, visit http://gerrit.ovirt.org/13915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54d938896e469c73800297c3d66185a439243a41
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to