Tomas Jelinek has posted comments on this change. Change subject: userportal,webadmin: implement VM builder ......................................................................
Patch Set 9: The fact that the builders in this patch don't have server calls does not mean they can not. Problems with having both methods in each builder: - it is a hard constraint that the common values in one direction have to be true for the opposite as well - forces you to implement both sides even you don't necessarily need them - stops you from designing the builders according to your needs because the infrastructure expects symmetry (e.g. what if I want something which gets all the datacenters from the server and creates a filtered list of them - e.g. has no input? Shell I implement the opposite direction that I get the list of datacenters and build up nothing from them?) If changing something in the infrastructure, I would go with Arik's idea of having builders with parameters. But as we already discussed this for about 3 and a half months, can we merge what we have now and maybe incrementally improve it when we will see how does it look like? When used on more places it will get more obvious what can be improved. And than we can do it. -- To view, visit http://gerrit.ovirt.org/13915 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54d938896e469c73800297c3d66185a439243a41 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
