Gilad Chaplik has posted comments on this change.
Change subject: findbugs: use StringBuilder in a for loop
......................................................................
Patch Set 4: (3 inline comments)
minor comments
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java
Line 252:
confirmModel.setHashName("import_template"); //$NON-NLS-1$
Line 253: String it =
StringHelper.trimEnd(importedTemplates.toString().trim(), ',');
Line 254:
confirmModel.setMessage(ConstantsManager.getInstance()
Line 255: .getMessages()
Line 256:
.importProcessHasBegunForTemplates(it));
it is redundant (used once)
Line 257: UICommand tempVar = new
UICommand("CancelConfirm", templateBackupModel); //$NON-NLS-1$
Line 258:
tempVar.setTitle(ConstantsManager.getInstance().getConstants().close());
Line 259: tempVar.setIsDefault(true);
Line 260: tempVar.setIsCancel(true);
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java
Line 470:
confirmModel.setHashName("import_virtual_machine"); //$NON-NLS-1$
Line 471: String iv =
StringHelper.trimEnd(importedVms.toString().trim(), ',');
Line 472:
confirmModel.setMessage(ConstantsManager.getInstance()
Line 473: .getMessages()
Line 474:
.importProcessHasBegunForVms(iv));
iv is redundant (used once)
Line 475: UICommand tempVar2 = new
UICommand("CancelConfirm", //$NON-NLS-1$
Line 476: vmBackupModel);
Line 477:
tempVar2.setTitle(ConstantsManager.getInstance().getConstants().close());
Line 478: tempVar2.setIsDefault(true);
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/CustomPropertyValidation.java
Line 94: for (String keyValue : getCustomPropertiesKeysList())
Line 95: {
Line 96: parameters.append(keyValue.substring(0,
keyValue.indexOf('='))).append(", "); //$NON-NLS-1$
Line 97: }
Line 98:
parameters.delete(parameters.length()-2,parameters.length()-1);
1) format
2) this code will throw an index OOB exception if length <= 1
Line 99:
Line 100: String reasonStr =
Line 101: ConstantsManager.getInstance()
Line 102: .getMessages()
--
To view, visit http://gerrit.ovirt.org/14367
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If11e9b335a741aaa364893474573d226ca9ece72
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
