Shahar Havivi has uploaded a new change for review.
Change subject: findbugs: use StringBuilder in a for loop
......................................................................
findbugs: use StringBuilder in a for loop
Change-Id: If11e9b335a741aaa364893474573d226ca9ece72
Signed-off-by: Shahar Havivi <shav...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/MultipleLdapQueryExecutionFormatter.java
M
backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java
M
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHDialogTest.java
M
backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/DomainsConfigurationEntry.java
M
backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/PasswordDomainsConfigurationEntry.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractDiskRemoveConfirmationPopupView.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractUiCommandButton.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageList.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/TaskListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BootSequenceModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/CustomPropertyValidation.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/DetailsRenderer.java
18 files changed, 66 insertions(+), 64 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/67/14367/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/MultipleLdapQueryExecutionFormatter.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/MultipleLdapQueryExecutionFormatter.java
index 60ac2d6..4241c91 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/MultipleLdapQueryExecutionFormatter.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/MultipleLdapQueryExecutionFormatter.java
@@ -42,15 +42,15 @@
}
protected String getFilter(LdapQueryMetadata queryMetadata, Object[]
filterParameters) {
- String filter = prefix;
+ StringBuilder filter = new StringBuilder(prefix);
for (Object currObject : filterParameters) {
- filter += String.format(queryMetadata.getFilter(), currObject);
+ filter.append(String.format(queryMetadata.getFilter(),
currObject));
}
- filter += suffix;
+ filter.append(suffix);
- return filter;
+ return filter.toString();
}
public String getPrefix() {
diff --git
a/backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java
b/backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java
index 7046da4..b0f9906 100644
---
a/backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java
+++
b/backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java
@@ -848,16 +848,16 @@
* @return the combined head and params
*/
public static String combine(String head, List<ParametersSet> params) {
- String combined_params = "";
+ StringBuilder combined_params = new StringBuilder("");
if (params != null) {
for (ParametersSet ps : params) {
for (Parameter param : ps.getParameters()) {
- combined_params += String.format(MATRIX_PARAMETER_TEMPLATE,
param.getName(), param.getValue());
+
combined_params.append(String.format(MATRIX_PARAMETER_TEMPLATE,
param.getName(), param.getValue()));
}
-
}
}
- return head + combined_params;
+ combined_params.insert(0, head);
+ return combined_params.toString();
}
/**
diff --git
a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHDialogTest.java
b/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHDialogTest.java
index 3505516..fd71b16 100644
---
a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHDialogTest.java
+++
b/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHDialogTest.java
@@ -378,9 +378,9 @@
final int NUM = 10000;
final int FACTOR = 5;
- String longText = "";
+ StringBuilder longText = new StringBuilder("");
for (int i=0;i<NUM/FACTOR;i++) {
- longText += LINE + "\n";
+ longText.append(LINE).append("\n");
}
List<String> expect = new LinkedList<String>();
@@ -392,7 +392,7 @@
List<String> send = new LinkedList<String>();
for (int i=0;i<NUM;i++) {
if (i % (NUM/FACTOR) == 0) {
- send.add(longText);
+ send.add(longText.toString());
}
else {
send.add(null);
diff --git
a/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/DomainsConfigurationEntry.java
b/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/DomainsConfigurationEntry.java
index f4d1a10..0713783 100644
---
a/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/DomainsConfigurationEntry.java
+++
b/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/DomainsConfigurationEntry.java
@@ -29,24 +29,24 @@
}
public String getDomainsConfigurationEntry() {
- String configurationEntry = "";
+ StringBuilder configurationEntry = new StringBuilder("");
boolean firstEntry = true;
for ( Entry<String,String> currEntry: valuePerDomain.entrySet() ) {
if (!firstEntry) {
- configurationEntry += domainSeperator;
+ configurationEntry.append(domainSeperator);
} else {
firstEntry = false;
}
- configurationEntry += currEntry.getKey();
+ configurationEntry.append(currEntry.getKey());
if (currEntry.getValue() != null) {
- configurationEntry += valueSeperator + currEntry.getValue();
+
configurationEntry.append(valueSeperator).append(currEntry.getValue());
}
}
- return configurationEntry;
+ return configurationEntry.toString();
}
// This method returns the entry for logging purposes
diff --git
a/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/PasswordDomainsConfigurationEntry.java
b/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/PasswordDomainsConfigurationEntry.java
index 41c4085..a76239a 100644
---
a/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/PasswordDomainsConfigurationEntry.java
+++
b/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/PasswordDomainsConfigurationEntry.java
@@ -11,23 +11,23 @@
// This method returns the entry for logging purposes
@Override
public String getDomainsLoggingEntry() {
- String configurationEntry = "";
+ StringBuilder configurationEntry = new StringBuilder("");
boolean firstEntry = true;
for (Entry<String, String> currEntry : valuePerDomain.entrySet()) {
if (!firstEntry) {
- configurationEntry += domainSeperator;
+ configurationEntry.append(domainSeperator);
} else {
firstEntry = false;
}
- configurationEntry += currEntry.getKey();
+ configurationEntry.append(currEntry.getKey());
if (currEntry.getValue() != null) {
- configurationEntry += valueSeperator + LOGGING_PASSWORD;
+
configurationEntry.append(valueSeperator).append(LOGGING_PASSWORD);
}
}
- return configurationEntry;
+ return configurationEntry.toString();
}
}
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractDiskRemoveConfirmationPopupView.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractDiskRemoveConfirmationPopupView.java
index 61dd8de..5c7ad12 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractDiskRemoveConfirmationPopupView.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractDiskRemoveConfirmationPopupView.java
@@ -58,16 +58,16 @@
}
String getFormattedNote() {
- String formattedNote = constants.empty();
+ StringBuilder formattedNote = new StringBuilder(constants.empty());
for (int i = 0; i < notes.size(); i++) {
String note = notes.get(i);
- formattedNote += constants.lineBreak();
- formattedNote += constants.htmlTab();
- formattedNote += note;
+ formattedNote.append(constants.lineBreak());
+ formattedNote.append(constants.htmlTab());
+ formattedNote.append(note);
}
- return formattedNote;
+ return formattedNote.toString();
}
}
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractUiCommandButton.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractUiCommandButton.java
index 9c278d0..875b26f 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractUiCommandButton.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractUiCommandButton.java
@@ -57,10 +57,12 @@
// Use prohibition reasons for tooltip if exist.
String title = ""; //$NON-NLS-1$
+ StringBuilder sb = new StringBuilder("");
if (!command.getExecuteProhibitionReasons().isEmpty()) {
for (String reason : command.getExecuteProhibitionReasons()) {
- title += reason + ","; //$NON-NLS-1$
+ sb.append(reason).append(","); //$NON-NLS-1$
}
+ title = sb.toString();
if (!title.equals("")) //$NON-NLS-1$
{
title = title.substring(0, title.length() -1);
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageList.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageList.java
index 5f3d8e7..5dc5c91 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageList.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageList.java
@@ -131,11 +131,11 @@
}
protected void updateInputTitle(ArrayList<String> grayOutReasons, Element
input) {
- String title = constants.empty();
+ StringBuilder title = new StringBuilder(constants.empty());
for (String reason : grayOutReasons) {
- title += reason + constants.space();
+ title.append(reason).append(constants.space());
}
- input.setTitle(title);
+ input.setTitle(title.toString());
}
protected void updateSelectedLunWarning(LunModel lunModel) {
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
index 3b09145..915b49c 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
@@ -983,17 +983,17 @@
String entityClause = array[0];
String searchClause = array[1];
- String tagsClause = ""; //$NON-NLS-1$
+ StringBuilder tagsClause = new StringBuilder(""); //$NON-NLS-1$
for (TagModel tag : tags)
{
- tagsClause += ("tag=" + tag.getName().getEntity());
//$NON-NLS-1$
+ tagsClause.append("tag=").append(tag.getName().getEntity());
//$NON-NLS-1$
if (tag != tags.get(tags.size() - 1))
{
- tagsClause += " or "; //$NON-NLS-1$
+ tagsClause.append(" or "); //$NON-NLS-1$
}
}
- prefix.argvalue = entityClause + ": " + tagsClause; //$NON-NLS-1$
+ prefix.argvalue = entityClause + ": " + tagsClause.toString();
//$NON-NLS-1$
search.argvalue = regex.replace(searchClause, "").trim();
//$NON-NLS-1$
}
// Split for system tree.
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java
index 0b95c47..5cd242a 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java
@@ -518,12 +518,12 @@
private String GetLocalStoragesFormattedString()
{
- String localStorages = ""; //$NON-NLS-1$
+ StringBuilder localStorages = new StringBuilder(""); //$NON-NLS-1$
for (StorageDomain a : Linq.<StorageDomain> cast(getSelectedItems()))
{
if (a.getStorageType() == StorageType.LOCALFS)
{
- localStorages += a.getStorageName() + ", "; //$NON-NLS-1$
+ localStorages.append(a.getStorageName()).append(", ");
//$NON-NLS-1$
}
}
return localStorages.substring(0, localStorages.length() - 2);
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/TaskListModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/TaskListModel.java
index 29940df..62e06ba 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/TaskListModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/TaskListModel.java
@@ -56,12 +56,12 @@
correlationTaskMap.put(rootTask.getCorrelationId(), entry);
String[] taskDescreptionArray =
rootTask.getCorrelationId().replace(_WEBADMIN_, "").split("_"); //$NON-NLS-1$
//$NON-NLS-2$
- String taskDesc = ""; //$NON-NLS-1$
+ StringBuilder taskDesc = new StringBuilder("");
//$NON-NLS-1$
for (int i = 1; i < taskDescreptionArray.length;
i++) {
- taskDesc += taskDescreptionArray[i] + " ";
//$NON-NLS-1$
+
taskDesc.append(taskDescreptionArray[i]).append(" "); //$NON-NLS-1$
}
rootTask.setId(task.getId());
- rootTask.setDescription(taskDesc);
+ rootTask.setDescription(taskDesc.toString());
taskListWithCorrelationFilter.add(rootTask);
}
Map.Entry<Job, ArrayList<Job>> entry =
correlationTaskMap.get(task.getCorrelationId());
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java
index 647d620..09f245d 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java
@@ -470,12 +470,12 @@
private String GetLocalStoragesFormattedString()
{
- String localStorages = ""; //$NON-NLS-1$
+ StringBuilder localStorages = new StringBuilder(""); //$NON-NLS-1$
for (StorageDomain a : Linq.<StorageDomain> cast(getSelectedItems()))
{
if (a.getStorageType() == StorageType.LOCALFS)
{
- localStorages += a.getStorageName() + ", "; //$NON-NLS-1$
+ localStorages.append(a.getStorageName()).append(", ");
//$NON-NLS-1$
}
}
return localStorages.substring(0, localStorages.length() - 2);
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
index 195a339..07d858b 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
@@ -524,7 +524,7 @@
ArrayList<StoragePool> dataCenterList =
(ArrayList<StoragePool>) getDataCenter().getItems();
ArrayList<StoragePool> localDCList = new ArrayList<StoragePool>();
- String dataCenterQueryLine = ""; //$NON-NLS-1$
+ StringBuilder dataCenterQueryLine = new StringBuilder("");
//$NON-NLS-1$
for (StoragePool storagePool : dataCenterList)
{
@@ -539,9 +539,9 @@
int i = 0;
for (; i < localDCList.size() - 1; i++)
{
- dataCenterQueryLine += "datacenter=" +
localDCList.get(i).getname() + " or "; //$NON-NLS-1$ //$NON-NLS-2$
+
dataCenterQueryLine.append("datacenter=").append(localDCList.get(i).getname()).append("
or "); //$NON-NLS-1$ //$NON-NLS-2$
}
- dataCenterQueryLine += "datacenter=" +
localDCList.get(i).getname(); //$NON-NLS-1$
+
dataCenterQueryLine.append("datacenter=").append(localDCList.get(i).getname());
//$NON-NLS-1$
AsyncQuery _asyncQuery = new AsyncQuery();
_asyncQuery.setModel(this);
@@ -556,7 +556,7 @@
storageModel.PostUpdateHost(hosts);
}
};
- Frontend.RunQuery(VdcQueryType.Search, new
SearchParameters("Hosts: status=Up " + dataCenterQueryLine, //$NON-NLS-1$
+ Frontend.RunQuery(VdcQueryType.Search, new
SearchParameters("Hosts: status=Up " + dataCenterQueryLine.toString(),
//$NON-NLS-1$
SearchType.VDS), _asyncQuery);
}
}
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java
index 331df36..e529076 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java
@@ -231,14 +231,14 @@
if (retVals != null &&
templateBackupModel.getSelectedItems().size() == retVals.size())
{
- String importedTemplates = ""; //$NONNLS1$
+ StringBuilder importedTemplates = new
StringBuilder(""); //$NONNLS1$
int counter = 0;
boolean toShowConfirmWindow = false;
for (Object a :
templateBackupModel.getSelectedItems())
{
VmTemplate template = (VmTemplate) a;
if (retVals.get(counter) != null &&
retVals.get(counter).getCanDoAction()) {
- importedTemplates += template.getName() +
", "; //$NON-NLS-1$
+
importedTemplates.append(template.getName()).append(", "); //$NON-NLS-1$
toShowConfirmWindow = true;
}
counter++;
@@ -250,10 +250,10 @@
.getConstants()
.importTemplatesTitle());
confirmModel.setHashName("import_template");
//$NON-NLS-1$
- importedTemplates =
StringHelper.trimEnd(importedTemplates.trim(), ',');
+ importedTemplates = new
StringBuilder(StringHelper.trimEnd(importedTemplates.toString().trim(), ','));
confirmModel.setMessage(ConstantsManager.getInstance()
.getMessages()
-
.importProcessHasBegunForTemplates(importedTemplates));
+
.importProcessHasBegunForTemplates(importedTemplates.toString()));
UICommand tempVar = new
UICommand("CancelConfirm", templateBackupModel); //$NON-NLS-1$
tempVar.setTitle(ConstantsManager.getInstance().getConstants().close());
tempVar.setIsDefault(true);
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java
index be786f1..13f73a8 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java
@@ -447,14 +447,14 @@
if (retVals != null
&& vmBackupModel.getSelectedItems().size() ==
retVals
.size()) {
- String importedVms = ""; //$NON-NLS-1$
+ StringBuilder importedVms = new StringBuilder("");
//$NON-NLS-1$
int counter = 0;
boolean toShowConfirmWindow = false;
for (Object item :
vmBackupModel.getSelectedItems()) {
VM vm = (VM) item;
if (retVals.get(counter) != null
&&
retVals.get(counter).getCanDoAction()) {
- importedVms += vm.getName() + ", ";
//$NON-NLS-1$
+ importedVms.append(vm.getName()).append(",
"); //$NON-NLS-1$
toShowConfirmWindow = true;
}
counter++;
@@ -468,10 +468,10 @@
.getConstants()
.importVirtualMachinesTitle());
confirmModel.setHashName("import_virtual_machine"); //$NON-NLS-1$
- importedVms =
StringHelper.trimEnd(importedVms.trim(), ',');
+ importedVms = new
StringBuilder(StringHelper.trimEnd(importedVms.toString().trim(), ','));
confirmModel.setMessage(ConstantsManager.getInstance()
.getMessages()
-
.importProcessHasBegunForVms(importedVms));
+
.importProcessHasBegunForVms(importedVms.toString()));
UICommand tempVar2 = new
UICommand("CancelConfirm", //$NON-NLS-1$
vmBackupModel);
tempVar2.setTitle(ConstantsManager.getInstance().getConstants().close());
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BootSequenceModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BootSequenceModel.java
index c1025fe..db11dd1 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BootSequenceModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BootSequenceModel.java
@@ -75,17 +75,17 @@
public BootSequence getSequence()
{
- String str = ""; //$NON-NLS-1$
+ StringBuilder str = new StringBuilder(""); //$NON-NLS-1$
for (EntityModel a : getItems())
{
if (a.getIsChangable())
{
BootSequence bs = (BootSequence) a.getEntity();
- str += bs.toString();
+ str.append(bs.toString());
}
}
- return !str.equals("") ? BootSequence.valueOf(str) : null;
//$NON-NLS-1$
+ return !str.equals("") ? BootSequence.valueOf(str.toString()) : null;
//$NON-NLS-1$
}
public BootSequenceModel()
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/CustomPropertyValidation.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/CustomPropertyValidation.java
index 398d1d7..3d55a04 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/CustomPropertyValidation.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/CustomPropertyValidation.java
@@ -89,18 +89,18 @@
}
if (!contains)
{
- String parameters = ""; //$NON-NLS-1$
+ StringBuilder parameters = new StringBuilder(""); //$NON-NLS-1$
for (String keyValue : getCustomPropertiesKeysList())
{
- parameters += keyValue.substring(0, keyValue.indexOf('='))
+ ", "; //$NON-NLS-1$
+ parameters.append(keyValue.substring(0,
keyValue.indexOf('='))).append(", "); //$NON-NLS-1$
}
- parameters = parameters.substring(0, parameters.length() - 2);
+ parameters = new StringBuilder(parameters.substring(0,
parameters.length() - 2));
String reasonStr =
ConstantsManager.getInstance()
.getMessages()
-
.customPropertyOneOfTheParamsIsntSupported(parameters);
+
.customPropertyOneOfTheParamsIsntSupported(parameters.toString());
ArrayList<String> reason = new ArrayList<String>();
reason.add(reasonStr);
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/DetailsRenderer.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/DetailsRenderer.java
index a24c978..76ab1f0 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/DetailsRenderer.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/DetailsRenderer.java
@@ -17,15 +17,15 @@
@Override
public String render(ArrayList<ValueLabel<V>> widgets) {
- String formattedStr = ""; //$NON-NLS-1$
+ StringBuilder formattedStr = new StringBuilder(""); //$NON-NLS-1$
for (int i = 0; i < widgets.size(); i++) {
- formattedStr += widgets.get(i).getElement().getInnerHTML() + " " +
delimiters[i]; //$NON-NLS-1$
+
formattedStr.append(widgets.get(i).getElement().getInnerHTML()).append("
").append(delimiters[i]); //$NON-NLS-1$
if (i < widgets.size() - 1) {
- formattedStr += ", "; //$NON-NLS-1$
+ formattedStr.append(", "); //$NON-NLS-1$
}
}
- return formattedStr;
+ return formattedStr.toString();
}
}
--
To view, visit http://gerrit.ovirt.org/14367
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If11e9b335a741aaa364893474573d226ca9ece72
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
