Alon Bar-Lev has posted comments on this change. Change subject: engine: Allow engine to configure management network ......................................................................
Patch Set 4: (1 inline comment) Thanks! Minor comment... .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java Line 91: private boolean _resultError = false; Line 92: private boolean _goingToReboot = false; Line 93: private boolean _aborted = false; Line 94: private boolean _installIncomplete = false; Line 95: private boolean _managementNetwork = false; Just a thought: Instead of boolean, have the caller set the name or null? Moving the call of NetworkUtils.getEngineNetwork() to command? Line 96: Line 97: private String _certificate; Line 98: private String _iptables = ""; Line 99: -- To view, visit http://gerrit.ovirt.org/14230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf82e10481e595d690e7ce894283b4ed5b9b3269 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Martin Pavlik <xpavl...@gmail.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
