Alon Bar-Lev has posted comments on this change.
Change subject: packaging: serve root customizable location resources
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java
Line 156: *
Line 157: * @return Expanded string.
Line 158: * @param value String.
Line 159: */
Line 160: public String expandString(String value) {
No... we use standard *NIX style substitution ${variable}, so java specific
format is no good in this case.
Line 161: for (;;) {
Line 162: Matcher refMatch = REF_EXPR.matcher(value);
Line 163: if (!refMatch.find()) {
Line 164: break;
--
To view, visit http://gerrit.ovirt.org/14354
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f845d36bb075c238e50606187bc22316713cdd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
