Alon Bar-Lev has posted comments on this change.

Change subject: packaging: serve root customizable location resources
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java
Line 179:      *
Line 180:      * @return Expanded string.
Line 181:      * @param value String.
Line 182:      */
Line 183:     public String expandString(String value) {
I just split the logic of expanding string to own function.

"${ENGINE_ETC}/alon" -> "/etc/ovirt-engine/alon"

This is handy at the web.xml of the root module.
Line 184:         for (;;) {
Line 185:             Matcher refMatch = REF_EXPR.matcher(value);
Line 186:             if (!refMatch.find()) {
Line 187:                 break;


--
To view, visit http://gerrit.ovirt.org/14354
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94f845d36bb075c238e50606187bc22316713cdd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to