Allon Mureinik has posted comments on this change. Change subject: pki: move configuration from vdc_options to EngineLocalConfig ......................................................................
Patch Set 8: (2 inline comments) Basically +1, giving -1 on the leftover ca.pem test file (see inline), just so this doesn't get merged by mistake. .................................................... File backend/manager/dbscripts/upgrade/03_01_1440_encrypt_chap_password.sh Line 1: #!/bin/bash why change to bash? Line 2: Line 3: #include db general functions Line 4: source ./dbfunctions.sh Line 5: .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetCACertificateQueryTest.java Line 15 Line 16 Line 17 Line 18 Line 19 Either recreate this test by mocking LocalConfig, or remove src/test/resources/ca/certs/ca.pem -- To view, visit http://gerrit.ovirt.org/14333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1764d9ca7a8c677401f721b3d89f45deff9c1f26 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Spenser Shumaker <sshum...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
