Alon Bar-Lev has posted comments on this change. Change subject: pki: move configuration from vdc_options to LocalConfig ......................................................................
Patch Set 6: > shouldn't engine-cleanup take care of removing FILE_ENGINE_CONF_PKI > introduced by this patch? I may be incorrect, but the enigne-cleanup is not really cleaning up any of the files but important pki and other external resources. There is no difference between this file and the legacy /etc/ovirt-engine/engine.conf which is not cleaned up too. This is resolved in the otopi setup by design. If we want to make the engine-cleanup clean all dirty files, we should do this in some generic manner as well... -- To view, visit http://gerrit.ovirt.org/14333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1764d9ca7a8c677401f721b3d89f45deff9c1f26 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
