Daniel Erez has uploaded a new change for review. Change subject: userportal: prevent an error dialog in login page ......................................................................
userportal: prevent an error dialog in login page Frontend -> handleActionResult: * Removed the redundant call to getEventsHandler().runActionFailed(failed) which invokes an error dialog without verifying 'isRaiseErrorModalPanel' flag first. * Removed the method as well since it's not used anymore. * Now, the error dialog will be invoked only after flag verification by raising frontendFailureEvent. * This issue of duplicate dialog invocation was hidden by now in UserPortal's login page by simply ignoring any error dialog (removed in Ibd2718649ab4031e6ff2b0d0e6c449f53164ff9f). Change-Id: Ib240214df319a0122ebcac82bf2b96d608997432 Bug-Url: https://bugzilla.redhat.com/957793 Signed-off-by: Daniel Erez <de...@redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/IFrontendEventsHandler.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java 3 files changed, 0 insertions(+), 9 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/92/14392/1 diff --git a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java index 04bebca..19b6c34 100644 --- a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java +++ b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java @@ -769,7 +769,6 @@ List<VdcReturnValueBase> failed = new ArrayList<VdcReturnValueBase>(); failed.add(result); translateErrors(failed); - getEventsHandler().runActionFailed(failed); callback.executed(f); } else if (result.getIsSyncronious() && result.getSucceeded() == false) { runActionExecutionFailed(actionType, result.getFault()); diff --git a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/IFrontendEventsHandler.java b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/IFrontendEventsHandler.java index 1b287aa..ea4407d 100644 --- a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/IFrontendEventsHandler.java +++ b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/IFrontendEventsHandler.java @@ -13,8 +13,6 @@ Boolean isRaiseErrorModalPanel(VdcQueryType queryType); - void runActionFailed(List<VdcReturnValueBase> returnValues); - void runActionExecutionFailed(VdcActionType action, VdcFault fault); void runMultipleActionFailed(VdcActionType action, List<VdcReturnValueBase> returnValues, List<VdcFault> faults); diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java index 034b970..b77411f 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java @@ -41,12 +41,6 @@ } @Override - public void runActionFailed(List<VdcReturnValueBase> returnValues) { - errorPopupManager.show( - messages.uiCommonRunActionFailed(ErrorMessageFormatter.formatReturnValues(returnValues))); - } - - @Override public void runActionExecutionFailed(VdcActionType action, VdcFault fault) { if (isRaiseErrorModalPanel(action, fault)) errorPopupManager.show(messages.uiCommonRunActionExecutionFailed( -- To view, visit http://gerrit.ovirt.org/14392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib240214df319a0122ebcac82bf2b96d608997432 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
