Tomas Jelinek has uploaded a new change for review. Change subject: userportal: closing RDP crashes IE ......................................................................
userportal: closing RDP crashes IE The problem was, that the MsRdpClient object has been removed from the body in the "OnDisconnected" event of the MsRdpClient which is too soon and causes the IE to crash - possibly because IE starts to destroy this object but after OnDisconnected callback returns, IE tries to give the control back to the MsRdpClient. Solved by just removing this line becaue the proper cleanup is already done in connect() method which removes the previous MsRdpClient if there is one. Change-Id: I6501bbd88ed77df2d3f8acb7fe61913a2888ce7f Bug-Url: https://bugzilla.redhat.com/909109 Signed-off-by: Tomas Jelinek <tjeli...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/RdpConnector.java 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/23/14223/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/RdpConnector.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/RdpConnector.java index 0dae88c..7b31501 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/RdpConnector.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/RdpConnector.java @@ -173,7 +173,6 @@ var extendedDiscReason = MsRdpClient.ExtendedDisconnectReason; var errorCodeEventArgs = @org.ovirt.engine.ui.uicommonweb.models.vms.ErrorCodeEventArgs::new(I)(disconnectCode); disconnectedeve...@org.ovirt.engine.ui.uicompat.Event::raise(Ljava/lang/Object;Lorg/ovirt/engine/ui/uicompat/EventArgs;)(model, errorCodeEventArgs); - $wnd.document.body.removeChild(MsRdpClient); } var server = th...@org.ovirt.engine.ui.common.uicommon.RdpConnector::getServer()(); -- To view, visit http://gerrit.ovirt.org/14223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6501bbd88ed77df2d3f8acb7fe61913a2888ce7f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
