[Engine-patches] Change in ovirt-engine[master]: findbugs: Method with Boolean return explicit null

[shavivi]

Shahar Havivi has uploaded a new change for review.

Change subject: findbugs: Method with Boolean return explicit null
......................................................................

findbugs: Method with Boolean return explicit null

Change-Id: Ibe28d8e00e2597cdbfd59c0acbb3c7dd8d08c99a
Signed-off-by: Shahar Havivi <shav...@redhat.com>
---
M 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/jsni/JsFunctionResultHelper.java
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/27/14227/1

diff --git 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
index cd2d284..7ef290b 100644
--- 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
+++ 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
@@ -786,7 +786,7 @@
             }
             return Boolean.parseBoolean(input.get(name).toString());
         }
-        return null;
+        return Boolean.FALSE;
     }
 
     private static void initDisks(Map<String, Object> vmStruct, VmDynamic vm) {
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/jsni/JsFunctionResultHelper.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/jsni/JsFunctionResultHelper.java
index 0f4a6c0..426023a 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/jsni/JsFunctionResultHelper.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/jsni/JsFunctionResultHelper.java
@@ -148,7 +148,7 @@
     }
 
     public Boolean getResultAsBoolean() {
-        return JsFunction.RESULT_TYPE_BOOLEAN.equals(resultType) ? (Boolean) 
resultValue : null;
+        return JsFunction.RESULT_TYPE_BOOLEAN.equals(resultType) ? (Boolean) 
resultValue : Boolean.FALSE;
     }
 
 }


--
To view, visit http://gerrit.ovirt.org/14227
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe28d8e00e2597cdbfd59c0acbb3c7dd8d08c99a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches