Vojtech Szocs has posted comments on this change. Change subject: findbugs: Method with Boolean return explicit null ......................................................................
Patch Set 13: Hi guys, regarding JsFunctionResultHelper "Boolean getResultAsBoolean()" method: * on wrong result type, returning null is intentional behavior, as we cannot parse boolean value from non-boolean result * invokeAndGetResultAsBoolean method contains "if (result != null)" check - if not null, returns result value, otherwise returns defaultValue So using "Boolean" instead of "boolean" is intentional in getResultAsBoolean method, null indicates a problem with result type. >From Findbugs perspective, is this really a serious code style violation? -- To view, visit http://gerrit.ovirt.org/14227 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe28d8e00e2597cdbfd59c0acbb3c7dd8d08c99a Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
