Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Improve form-based sub tabs ......................................................................
Patch Set 10: > Shouldn't a span/div also auto wrap if the proper styles are applied? Yes, but the main problem here is multiple (individual) form item elements having different label widths. If we want to achieve consistent looks, i.e. same label width for all form items, we need to do that explicitly like FormBuilder.setColumnLabelWidth(). On the other hand, HTML table algorithm could take care of calculating label width across all related form items, so we wouldn't have to set label width explicitly. This way, label width would be auto-adjusted on every locale, be it English, Japanese, etc. -- To view, visit http://gerrit.ovirt.org/12325 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b2f2577b1b488d5514dc05c2590a2bb53fcfe4f Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
