Sahina Bose has posted comments on this change.

Change subject: engine: Gluster hook content query
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterHookContentQuery.java
Line 17: 
Line 18:     @Override
Line 19:     protected void executeQueryCommand() {
Line 20:         if (getParameters().getGlusterServerId() == null) {
Line 21:             
getQueryReturnValue().setReturnValue(getGlusterHookDao().getGlusterHookContent(getParameters().getGlusterHookId()));
The db stores decoded content. So no need to decode again.
Line 22:         } else {
Line 23:             GlusterHookEntity hook = 
getGlusterHookDao().getById(getParameters().getGlusterHookId());
Line 24:             VDSReturnValue returnValue =
Line 25:                     runVdsCommand(VDSCommandType.GetGlusterHookContent,


--
To view, visit http://gerrit.ovirt.org/12219
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie24d1132fc214661cd2c2e3071f641812d19cd4f
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to