Eli Mesika has posted comments on this change. Change subject: core,webadmin: Show Pools tab based on tree ......................................................................
Patch Set 2: (3 inline comments) .................................................... File backend/manager/dbscripts/create_views.sql Line 760: Line 761: Line 762: Line 763: Line 764: CREATE OR REPLACE VIEW vm_pools_view AS please remove TWS Line 765: SELECT vm_pools.vm_pool_id, vm_pools.vm_pool_name, vm_pools.vm_pool_description, vm_pools.vm_pool_type, vm_pools.parameters, vm_pools.prestarted_vms, vm_pools.vds_group_id, vds_groups.name AS vds_group_name, storage_pool.name as storage_pool_name, storage_pool.id as storage_pool_id Line 766: FROM vm_pools Line 767: JOIN vds_groups ON vm_pools.vds_group_id = vds_groups.vds_group_id Line 768: JOIN storage_pool ON storage_pool.id = vds_groups.storage_pool_id; Line 768: JOIN storage_pool ON storage_pool.id = vds_groups.storage_pool_id; Line 769: Line 770: Line 771: Line 772: CREATE OR REPLACE VIEW vm_pools_full_view AS same Line 773: SELECT vmp.vm_pool_id, vmp.vm_pool_name, vmp.vm_pool_description, vmp.vm_pool_type, vmp.parameters, vmp.prestarted_vms, vmp.vds_group_id, vmp.vds_group_name, ( SELECT count(vm_pool_map.vm_pool_id) AS expr1 Line 774: FROM vm_pools_view v1 Line 775: LEFT JOIN vm_pool_map ON v1.vm_pool_id = vm_pool_map.vm_pool_id AND v1.vm_pool_id = vmp.vm_pool_id) AS assigned_vm_count, ( SELECT count(v2.vm_pool_id) AS expr1 Line 776: FROM vm_pools v2 Line 774: FROM vm_pools_view v1 Line 775: LEFT JOIN vm_pool_map ON v1.vm_pool_id = vm_pool_map.vm_pool_id AND v1.vm_pool_id = vmp.vm_pool_id) AS assigned_vm_count, ( SELECT count(v2.vm_pool_id) AS expr1 Line 776: FROM vm_pools v2 Line 777: LEFT JOIN vm_pool_map vm_pool_map_1 ON v2.vm_pool_id = vm_pool_map_1.vm_pool_id AND v2.vm_pool_id = vmp.vm_pool_id Line 778: LEFT JOIN vm_dynamic ON vm_pool_map_1.vm_guid = vm_dynamic.vm_guid same Line 779: WHERE vm_dynamic.status <> ALL (ARRAY[0, 15]) Line 780: GROUP BY v2.vm_pool_id) AS vm_running_count, vmp.storage_pool_name, vmp.storage_pool_id Line 781: FROM vm_pools_view vmp; Line 782: -- To view, visit http://gerrit.ovirt.org/14073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39c39366865ff6a62d30fab993685c72e0c39e10 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspe...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Libor Spevak <lspe...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
