Laszlo Hornyak has posted comments on this change. Change subject: core,webadmin: Show Pools tab based on tree ......................................................................
Patch Set 1: Verified; Looks good to me, but someone else must approve (1 inline comment) works fine. Please consider breaking the SQL part to cleanup and new columns. .................................................... File backend/manager/dbscripts/create_views.sql Line 777: LEFT JOIN vm_pool_map vm_pool_map_1 ON v2.vm_pool_id = vm_pool_map_1.vm_pool_id AND v2.vm_pool_id = vmp.vm_pool_id Line 778: LEFT JOIN vm_dynamic ON vm_pool_map_1.vm_guid = vm_dynamic.vm_guid Line 779: WHERE vm_dynamic.status <> ALL (ARRAY[0, 15]) Line 780: GROUP BY v2.vm_pool_id) AS vm_running_count, vmp.storage_pool_name, vmp.storage_pool_id Line 781: FROM vm_pools_view vmp; understand the motivation but this part of the change is hard to read. Line 782: Line 783: Line 784: Line 785: CREATE OR REPLACE VIEW permissions_view -- To view, visit http://gerrit.ovirt.org/14073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39c39366865ff6a62d30fab993685c72e0c39e10 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspe...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
