Sandro Bonazzola has posted comments on this change.

Change subject: packaging: stricter FQDN validation
......................................................................


Patch Set 4: (1 inline comment)

I'll send another patch

....................................................
File packaging/fedora/setup/common_utils.py
Line 640: 
Line 641:     iplist = []
Line 642:     for interface, loopback in interfaces.iteritems():
Line 643:         if not loopback:
Line 644:             iplist.extend(addresses[interface])
ok
Line 645:     return set(iplist)
Line 646: 
Line 647: 
Line 648: def getCurrentDateTime(isUtc=None):


--
To view, visit http://gerrit.ovirt.org/13933
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I512446c80dfa9c83adb179a445bfae82736d403f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to