Sandro Bonazzola has posted comments on this change. Change subject: packaging: stricter FQDN validation ......................................................................
Patch Set 2: (1 inline comment) .................................................... File packaging/fedora/setup/common_utils.py Line 628: addresses[currentDevice] = [] Line 629: else: Line 630: foundIp = ipaddrPattern.search(line) Line 631: if foundIp is not None: Line 632: addresses[currentDevice].append(foundIp.group(1)) done with a change for avoiding errors if an interface has no configured addresses Line 633: except Exception: Line 634: logging.error(traceback.format_exc()) Line 635: raise Exception(output_messages.ERR_EXP_GET_CFG_IPS) Line 636: -- To view, visit http://gerrit.ovirt.org/13933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I512446c80dfa9c83adb179a445bfae82736d403f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
