Laszlo Hornyak has uploaded a new change for review.
Change subject: engine: unit test for isCpuPinningValid
......................................................................
engine: unit test for isCpuPinningValid
Adds a negative test for the case when there is pinning but no pinned to
a host.
Change-Id: Ifd736d87851d2250358a13c78a64f1a05d23db72
Signed-off-by: Laszlo Hornyak <lhorn...@redhat.com>
---
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmManagementCommandBaseTest.java
1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/91/13991/1
diff --git
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmManagementCommandBaseTest.java
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmManagementCommandBaseTest.java
index f439820..26d52ac 100644
---
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmManagementCommandBaseTest.java
+++
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmManagementCommandBaseTest.java
@@ -19,6 +19,20 @@
public class VmManagementCommandBaseTest {
+ @Test
+ public void isCpuPinningValidWithoutPinnedHost() {
+ VmManagementCommandBase<VmManagementParametersBase> test =
+ spy(new
VmManagementCommandBase<VmManagementParametersBase>(Guid.Empty));
+ VmStatic vmStatic = new VmStatic();
+ vmStatic.setNumOfSockets(6);
+ vmStatic.setCpuPerSocket(2);
+ vmStatic.setDedicatedVmForVds(null);
+ Assert.assertFalse(test.isCpuPinningValid("0#0", vmStatic));
+
Assert.assertFalse(test.getReturnValue().getCanDoActionMessages().isEmpty());
+ Assert.assertFalse(test.getReturnValue()
+ .getCanDoActionMessages()
+
.contains(VdcBllMessages.ACTION_TYPE_FAILED_VM_CANNOT_BE_PINNED_TO_CPU_WITH_UNDEFINED_HOST));
+ }
@Test
public void isCpuPinningValid() {
--
To view, visit http://gerrit.ovirt.org/13991
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd736d87851d2250358a13c78a64f1a05d23db72
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
