Alon Bar-Lev has posted comments on this change.

Change subject: engine: Added new canDoAction check for gluster
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
Line 346:                 }
Line 347:             }
Line 348: 
Line 349:             try {
Line 350:                 if(serverHasPeers()) {
If this to remain, please accept the same sshclient object from the canConnect, 
so we do not open multiple sessions.

Thanks!
Line 351:                     
addCanDoActionMessage(VdcBllMessages.SERVER_ALREADY_PART_OF_ANOTHER_CLUSTER);
Line 352:                     returnValue = false;
Line 353:                 }
Line 354:             } catch (AuthenticationException e) {


--
To view, visit http://gerrit.ovirt.org/13980
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81427fa940bf1edabf316acebc428becac0171f8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to