Alon Bar-Lev has posted comments on this change. Change subject: engine: Added new canDoAction check for gluster ......................................................................
Patch Set 1: Am not sure that installed failed is not user friendly in these cases, as you do want to see the event log, which is attached to the host entity. Performing ssh twice to same host is not good approach as in future we may need to setup ssh environment and/or user to properly access the host, I worked very hard to eliminate multiple access to the host at deployment time, this patch breaks this effort. A better solution would be to wait for host-deploy to finish and not adding the host to database if it fails validation, I mean, if the 'user friendly' argument is accepted. Then still we have single execution of session/code at host. However, as far as I understand within current design of the backend, the install failed status is the expected behavior, which allows admin to review messages and act upon these, there may be more than one validation issue, examples of such: duplicate UUID, no UUID, duplicate name, invalid RHN channel, etc... -- To view, visit http://gerrit.ovirt.org/13980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81427fa940bf1edabf316acebc428becac0171f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
