Daniel Erez has uploaded a new change for review. Change subject: webadmin: Japanese - truncated text in snapshots sub-tab ......................................................................
webadmin: Japanese - truncated text in snapshots sub-tab VMs - snapshots sub-tab: - fix columns width. - change header cells 'white-space' to normal (to allow multiple rows). Change-Id: I02f7afb0b7521886df2cf0d99fa9d2b19e077d31 Bug-Url: https://bugzilla.redhat.com/927617 Signed-off-by: Daniel Erez <de...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoPanel.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/PopupCellTable.css 3 files changed, 11 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/88/13888/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java index 4d4745a..70b9c28 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java @@ -645,6 +645,9 @@ @DefaultStringValue("Allocation Policy") String allocationDisk(); + @DefaultStringValue("Allocation") + String allocationDiskShort(); + @DefaultStringValue("Interface") String interfaceDisk(); diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoPanel.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoPanel.java index cdc2586..004a6cc 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoPanel.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoPanel.java @@ -124,7 +124,7 @@ return object.getDiskAlias(); } }; - disksTable.addColumn(aliasColumn, constants.aliasDisk()); + disksTable.addColumn(aliasColumn, constants.aliasDisk(), "70px"); //$NON-NLS-1$ DiskSizeColumn<DiskImage> sizeColumn = new DiskSizeColumn<DiskImage>() { @Override @@ -132,7 +132,7 @@ return object.getSize(); } }; - disksTable.addColumn(sizeColumn, constants.provisionedSizeDisk()); + disksTable.addColumn(sizeColumn, constants.provisionedSizeDisk(), "70px"); //$NON-NLS-1$ DiskSizeColumn<DiskImage> actualSizeColumn = new DiskSizeColumn<DiskImage>() { @Override @@ -140,7 +140,7 @@ return object.getActualSizeFromDiskImage(); } }; - disksTable.addColumn(actualSizeColumn, constants.sizeDisk()); + disksTable.addColumn(actualSizeColumn, constants.sizeDisk(), "70px"); //$NON-NLS-1$ TextColumnWithTooltip<DiskImage> allocationColumn = new EnumColumn<DiskImage, VolumeType>() { @Override @@ -148,7 +148,7 @@ return VolumeType.forValue(object.getVolumeType().getValue()); } }; - disksTable.addColumn(allocationColumn, constants.allocationDisk(), "60px"); //$NON-NLS-1$ + disksTable.addColumn(allocationColumn, constants.allocationDiskShort(), "70px"); //$NON-NLS-1$ TextColumnWithTooltip<DiskImage> interfaceColumn = new TextColumnWithTooltip<DiskImage>() { @Override @@ -156,7 +156,7 @@ return object.getDiskInterface().toString(); } }; - disksTable.addColumn(interfaceColumn, constants.interfaceDisk(), "60px"); //$NON-NLS-1$ + disksTable.addColumn(interfaceColumn, constants.interfaceDisk(), "90px"); //$NON-NLS-1$ TextColumnWithTooltip<DiskImage> statusColumn = new EnumColumn<DiskImage, ImageStatus>() { @Override @@ -172,7 +172,7 @@ return object.getCreationDate(); } }; - disksTable.addColumn(dateCreatedColumn, constants.creationDateDisk(), "80px"); //$NON-NLS-1$ + disksTable.addColumn(dateCreatedColumn, constants.creationDateDisk(), "70px"); //$NON-NLS-1$ TextColumnWithTooltip<DiskImage> descriptionColumn = new TextColumnWithTooltip<DiskImage>() { @Override diff --git a/frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/PopupCellTable.css b/frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/PopupCellTable.css index c637d9b..0d1fa8d 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/PopupCellTable.css +++ b/frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/PopupCellTable.css @@ -27,7 +27,7 @@ font-size: 11px; background-color: #F0F2FF; height: 28px; - white-space: nowrap; + white-space: normal; } .cellTableCell { @@ -62,4 +62,4 @@ @sprite .cellTableLoading { gwt-image: 'cellTableLoading'; margin: 3px; -} \ No newline at end of file +} -- To view, visit http://gerrit.ovirt.org/13888 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I02f7afb0b7521886df2cf0d99fa9d2b19e077d31 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
