Daniel Erez has uploaded a new change for review. Change subject: webadmin: Japanese - truncated text in disk dialog ......................................................................
webadmin: Japanese - truncated text in disk dialog Attach Disk dialog: fix columns' width. Change-Id: Ie630bbc4b0647d04454ecc585f5c07f150b580ed Bug-Url: https://bugzilla.redhat.com/927613 Signed-off-by: Daniel Erez <de...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmDiskPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmDiskPopupView.java 3 files changed, 13 insertions(+), 13 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/87/13887/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java index 59962db..6a7c5b9 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java @@ -351,7 +351,7 @@ return diskImage.getStoragesNames().get(0); } }; - internalDiskTable.addColumn(storageDomainColumn, constants.storageDomainVmDiskTable()); + internalDiskTable.addColumn(storageDomainColumn, constants.storageDomainVmDiskTable(), "100px"); //$NON-NLS-1$ TextColumnWithTooltip<EntityModel> interfaceColumn = new EnumColumn<EntityModel, DiskInterface>() { @Override @@ -360,7 +360,7 @@ return disk.getDiskInterface(); } }; - internalDiskTable.addColumn(interfaceColumn, constants.interfaceVmDiskPopup(), "55px"); //$NON-NLS-1$ + internalDiskTable.addColumn(interfaceColumn, constants.interfaceVmDiskPopup(), "90px"); //$NON-NLS-1$ internalDiskTable.addColumn(new ImageResourceColumn<EntityModel>() { @Override @@ -393,7 +393,7 @@ return disk.getDiskAlias(); } }; - externalDiskTable.addColumn(aliasColumn, constants.aliasVmDiskTable()); + externalDiskTable.addColumn(aliasColumn, constants.aliasVmDiskTable(), "60px"); //$NON-NLS-1$ TextColumnWithTooltip<EntityModel> descriptionColumn = new TextColumnWithTooltip<EntityModel>() { @Override @@ -402,7 +402,7 @@ return disk.getDiskDescription(); } }; - externalDiskTable.addColumn(descriptionColumn, constants.descriptionVmDiskTable()); + externalDiskTable.addColumn(descriptionColumn, constants.descriptionVmDiskTable(), "85px"); //$NON-NLS-1$ TextColumnWithTooltip<EntityModel> lunIdColumn = new TextColumnWithTooltip<EntityModel>() { @Override @@ -411,7 +411,7 @@ return disk.getLun().getLUN_id(); } }; - externalDiskTable.addColumn(lunIdColumn, constants.lunIdSanStorage()); + externalDiskTable.addColumn(lunIdColumn, constants.lunIdSanStorage(), "60px"); //$NON-NLS-1$ TextColumnWithTooltip<EntityModel> idColumn = new TextColumnWithTooltip<EntityModel>() { @Override @@ -420,7 +420,7 @@ return disk.getId().toString(); } }; - externalDiskTable.addColumn(idColumn, constants.idVmDiskTable()); + externalDiskTable.addColumn(idColumn, constants.idVmDiskTable(), "60px"); //$NON-NLS-1$ DiskSizeColumn<EntityModel> sizeColumn = new DiskSizeColumn<EntityModel>(DiskSizeUnit.GIGABYTE) { @Override @@ -429,7 +429,7 @@ return (long) disk.getLun().getDeviceSize(); } }; - externalDiskTable.addColumn(sizeColumn, constants.devSizeSanStorage(), "60px"); //$NON-NLS-1$ + externalDiskTable.addColumn(sizeColumn, constants.devSizeSanStorage(), "70px"); //$NON-NLS-1$ TextColumnWithTooltip<EntityModel> pathColumn = new TextColumnWithTooltip<EntityModel>() { @Override @@ -447,7 +447,7 @@ return disk.getLun().getVendorId(); } }; - externalDiskTable.addColumn(vendorIdColumn, constants.vendorIdSanStorage()); + externalDiskTable.addColumn(vendorIdColumn, constants.vendorIdSanStorage(), "70px"); //$NON-NLS-1$ TextColumnWithTooltip<EntityModel> productIdColumn = new TextColumnWithTooltip<EntityModel>() { @Override @@ -456,7 +456,7 @@ return disk.getLun().getProductId(); } }; - externalDiskTable.addColumn(productIdColumn, constants.productIdSanStorage()); + externalDiskTable.addColumn(productIdColumn, constants.productIdSanStorage(), "70px"); //$NON-NLS-1$ TextColumnWithTooltip<EntityModel> serialColumn = new TextColumnWithTooltip<EntityModel>() { @Override @@ -465,7 +465,7 @@ return disk.getLun().getSerial(); } }; - externalDiskTable.addColumn(serialColumn, constants.serialSanStorage()); + externalDiskTable.addColumn(serialColumn, constants.serialSanStorage(), "70px"); //$NON-NLS-1$ TextColumnWithTooltip<EntityModel> interfaceColumn = new EnumColumn<EntityModel, DiskInterface>() { @Override @@ -474,7 +474,7 @@ return disk.getDiskInterface(); } }; - externalDiskTable.addColumn(interfaceColumn, constants.interfaceVmDiskPopup(), "55px"); //$NON-NLS-1$ + externalDiskTable.addColumn(interfaceColumn, constants.interfaceVmDiskPopup(), "90px"); //$NON-NLS-1$ externalDiskTable.addColumn(new ImageResourceColumn<EntityModel>() { @Override diff --git a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmDiskPopupView.java b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmDiskPopupView.java index 5becfa2..758438a 100644 --- a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmDiskPopupView.java +++ b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmDiskPopupView.java @@ -20,7 +20,7 @@ @Inject public VmDiskPopupView(EventBus eventBus, ApplicationResources resources, ApplicationConstants constants) { - super(eventBus, resources, new VmDiskPopupWidget(constants, resources, false), "725px", "615px"); //$NON-NLS-1$ //$NON-NLS-2$ + super(eventBus, resources, new VmDiskPopupWidget(constants, resources, false), "785px", "615px"); //$NON-NLS-1$ //$NON-NLS-2$ ViewIdHandler.idHandler.generateAndSetIds(this); asWidget().enableResizeSupport(true); } diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmDiskPopupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmDiskPopupView.java index 42be3ee..9ec24c0 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmDiskPopupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmDiskPopupView.java @@ -20,7 +20,7 @@ @Inject public VmDiskPopupView(EventBus eventBus, ApplicationResources resources, ApplicationConstants constants) { - super(eventBus, resources, new VmDiskPopupWidget(constants, resources, true), "725px", "615px"); //$NON-NLS-1$ //$NON-NLS-2$ + super(eventBus, resources, new VmDiskPopupWidget(constants, resources, true), "785px", "615px"); //$NON-NLS-1$ //$NON-NLS-2$ ViewIdHandler.idHandler.generateAndSetIds(this); asWidget().enableResizeSupport(true); } -- To view, visit http://gerrit.ovirt.org/13887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie630bbc4b0647d04454ecc585f5c07f150b580ed Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
