Juan Hernandez has posted comments on this change.
Change subject: core: Compatibility of db scripts with MacOS.
......................................................................
Patch Set 2: (2 inline comments)
I don't see the sysfunctions.sh file in the patch.
Also try to use spaces instead of tabs for indentation.
....................................................
File backend/manager/dbscripts/dbfunctions.sh
Line 1: #!/bin/bash
Line 2:
Line 3: source ./sysfunctions.sh
Maybe something like this:
. "$(dirname "$0")"/sysfunctions.sh
Just to make sure that this will work even if invoked from a different
directory. It isn't invoked in that way currenctly, as it only called by other
scripts that already cd into the correct directory, so not that important.
Line 4: # $1 - the command to execute
Line 5: # $2 - the database to use
Line 6: # $3 - db hostname (default 'localhost' or '')
Line 7: # $4 - db port (default '5432')
Line 322: disable_gaps_from="3010910"
Line 323: files=$(get_files "upgrade" 1)
Line 324: for file in $(ls -1 $files); do
Line 325: before=$(get_db_time)
Line 326: checksum=$(md5calc $file)
We used "cut -d ..." to get only the first part of the output of md5sum,
skipping the name of the file. Don't we need that?
Line 327: # upgrade/dd_dd_dddd* => dddddddd
Line 328: ver="${file:8:2}${file:11:2}${file:14:4}"
Line 329: if [ "$ver" -gt "$current" ] ; then
Line 330: # we should remove leading zero in order not to treat
number as octal
--
To view, visit http://gerrit.ovirt.org/13233
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I97df4a9c8ea0c2ca0fdf861932a97afb978e56c4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <a...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
