Daniel Erez has posted comments on this change.
Change subject: userportal,webadmin: Persist the changes from console popup
......................................................................
Patch Set 2: Looks good to me, approved
(5 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseUtilsModule.java
Line 5:
Line 6: import com.google.gwt.inject.client.AbstractGinModule;
Line 7: import com.google.inject.Singleton;
Line 8:
Line 9: public class BaseUtilsModule extends AbstractGinModule {
Not sure it justifies a new class but if so, then ConsoleUtils and
ConsoleManager should also be added here.
Line 10:
Line 11: @Override
Line 12: protected void configure() {
Line 13:
bind(ConsoleOptionsFrontendPersister.class).to(ConsoleOptionsFrontendPersisterImpl.class).in(Singleton.class);
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleOptionsFrontendPersisterImpl.java
Line 149:
Line 150: private ConsoleContext context;
Line 151:
Line 152: public KeyMaker(String vmId, ConsoleContext context) {
Line 153: super();
no need to call super
Line 154: this.vmId = vmId;
Line 155: this.context = context;
Line 156: }
Line 157:
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
Line 812:
Line 813: ConsolePopupModel model = new ConsolePopupModel();
Line 814: model.setConsoleContext(ConsoleContext.WA);
Line 815: model.setModel(this);
Line 816:
redundant line
Line 817: model.setHashName("editConsole"); //$NON-NLS-1$
Line 818: setWindow(model);
Line 819:
Line 820: UICommand saveCommand = new UICommand("OnEditConsoleSave",
this); //$NON-NLS-1$
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/UtilsModule.java
Line 13:
Line 14: @Override
Line 15: protected void configure() {
Line 16: super.configure();
Line 17: bind(ConsoleUtils.class).in(Singleton.class);
should probably be moved to BaseUtilsModule
Line 18:
bind(MainTabBasicListItemMessagesTranslator.class).in(Singleton.class);
Line 19: bind(ConnectAutomaticallyProvider.class).in(Singleton.class);
Line 20: bind(ConnectAutomaticallyManager.class).in(Singleton.class);
Line 21: bind(ConsoleManager.class).in(Singleton.class);
Line 17: bind(ConsoleUtils.class).in(Singleton.class);
Line 18:
bind(MainTabBasicListItemMessagesTranslator.class).in(Singleton.class);
Line 19: bind(ConnectAutomaticallyProvider.class).in(Singleton.class);
Line 20: bind(ConnectAutomaticallyManager.class).in(Singleton.class);
Line 21: bind(ConsoleManager.class).in(Singleton.class);
same
Line 22: }
Line 23:
--
To view, visit http://gerrit.ovirt.org/13274
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I847e17c6e28db7921f0bc162f0ff70399e671a03
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
