Michael Kublin has posted comments on this change. Change subject: getAllTasksList\Status with spUUID retrieves info only if host is the SPM ......................................................................
Patch Set 2: I would prefer that you didn't submit this 1. We usually can send a spm call to host that not spm - race, this race can not be solved, on such race we usually will get exception "Not SPM" and this behaviour should not be fix, because it ok. 2. Now a patch is introducing distinguish between getAllTaskStatuses for regular host command and SPM , if call is unique for SPM , the change should be done inside IrsProxy and not as workaround in side VdsServerProxy. Now the interesting question if we really need distinguish between SPM and HSM command, maybe SPM command is enought? -- To view, visit http://gerrit.ovirt.org/13450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff7d8db4e4ad6b3f809085aff7216ac8a457b633 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
