Juan Hernandez has posted comments on this change. Change subject: packaging: engine-service: rework start pid file handling ......................................................................
Patch Set 3: (1 inline comment) .................................................... Commit Message Line 6: Line 7: packaging: engine-service: rework start pid file handling Line 8: Line 9: There is no reason to force user to explicit stop and start the service Line 10: in case pid file contains non running process. The reason is explained in the bug. If you think that this should not work like that reopen the bug, reopen the discussion, and then once everybody agrees we can apply this change. Line 11: Line 12: Change-Id: I8d8a7f8f8b7f5941f447df3d279686b973b5c393 -- To view, visit http://gerrit.ovirt.org/13415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d8a7f8f8b7f5941f447df3d279686b973b5c393 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches