Alon Bar-Lev has posted comments on this change.

Change subject: packaging: engine-service: rework start pid file handling
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File packaging/fedora/engine-service.py.in
Line 393:     # If the PID already exists then we need to check if the
Line 394:     # process is running and tell the user that the service needs
Line 395:     # to be restarted:
Line 396:     if enginePid:
Line 397:         if isProcessRunning(enginePid):
Probably... I did not want to create too much noise, or I had rewritten almost 
all... :)

Will change.
Line 398:             syslog.syslog(syslog.LOG_WARNING,
Line 399:                 "The engine PID file \"%s\" exists and the "
Line 400:                 "process %d is running." %
Line 401:                 (enginePidFile, enginePid))


--
To view, visit http://gerrit.ovirt.org/13415
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8d8a7f8f8b7f5941f447df3d279686b973b5c393
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to