Daniel Erez has posted comments on this change.
Change subject: core: update DiskImageDynamic on RemoveSnapshot
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java
Line 90: setSucceeded(true);
Line 91: }
Line 92:
Line 93: private void updateDiskImageDynamic() {
Line 94: VDSReturnValue ret =
Backend.getInstance().getResourceManager().RunVdsCommand(
Done
Line 95: VDSCommandType.GetImageInfo,
Line 96: new
GetImageInfoVDSCommandParameters(getDestinationDiskImage().getStoragePoolId().getValue(),
Line 97:
getDestinationDiskImage().getStorageIds().get(0),
Line 98: getDestinationDiskImage().getId(),
Line 100:
Line 101: DiskImage imageFromIRS = (DiskImage) ret.getReturnValue();
Line 102: DiskImageDynamic diskImageDynamic =
getDiskImageDynamicDAO().get(getDestinationDiskImage().getImageId());
Line 103:
Line 104: // Update image's actual size in DB
I find it more readable this way.
Line 105: if (imageFromIRS != null && diskImageDynamic != null) {
Line 106:
diskImageDynamic.setactual_size(imageFromIRS.getActualSizeFromDiskImage());
Line 107: getDiskImageDynamicDAO().update(diskImageDynamic);
Line 108: }
--
To view, visit http://gerrit.ovirt.org/13243
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie124fb42c34860ee349e91172e0248a2d824b127
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
