Vojtech Szocs has posted comments on this change. Change subject: webadmin: fix NPE in WebAdminHostPageServletTest ......................................................................
Patch Set 1: Looks good to me, approved Allon is right, inter-dependencies between two methods should be controlled explicitly. However, it's still strange why the test works in some cases and doesn't in other cases, the only inter-dependency is "mockPluginDefinitionsArray" reference variable that's just used (no read/write) within setUpMockRequest() method. Anyway, the patch looks good. Maybe setUpMockRequest() can now be renamed to just setUp(), no big deal though :) -- To view, visit http://gerrit.ovirt.org/13350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib76f7bd842d3b58c522e3e97609a9b55d5a79902 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
