Daniel Erez has posted comments on this change.
Change subject: webadmin: show quota tab only for correct DCs
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
Line 540: || model.getType() == SystemTreeItemType.System);
Line 541:
Line 542: //only show quota if you select a datacenter that is not
"quota disabled"
Line 543: if (model.getType() == SystemTreeItemType.DataCenter) {
Line 544: storage_pool dataCenter = (storage_pool)model.getEntity();
use formatter
Line 545:
quotaList.setIsAvailable(dataCenter.getQuotaEnforcementType() !=
QuotaEnforcementTypeEnum.DISABLED);
Line 546: } else {
Line 547: quotaList.setIsAvailable(false);
Line 548: }
Line 613: // quota should not be seen system wide
Line 614: if (getSelectedItem() == quotaList) {
Line 615: setSelectedItem(dataCenterList);
Line 616: } else if (getSelectedItem() == null) {
Line 617: {
redundant brackets
Line 618: setSelectedItem(getDefaultItem());
Line 619: }
Line 620: }
Line 621: break;
--
To view, visit http://gerrit.ovirt.org/13305
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7da842adb808838222e5fa40762e7782cd121f6c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <nslom...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: noam slomianko <nslom...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
