Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove GetVmsRunningOnVDS
......................................................................
core: Remove GetVmsRunningOnVDS
GetVmsRunningOnVDSQuery is not used anywhere in the
code, and thus should be removed.
This patch removes the following:
1. The GetVmsRunningOnVDSQuery class.
2. The GetVmsRunningOnVDSParameters class only
used by the aforementioned query class.
3. The GetVmsRunningOnVDS constant in VdcQueryType
corresponding to the aforementioned query class.
Change-Id: Iba10fb35ece3a9bc6ba9f5cbe43086d14e440262
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
D
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsRunningOnVDSCountQuery.java
D
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsRunningOnVDSCountParameters.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
3 files changed, 0 insertions(+), 37 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/88/13288/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsRunningOnVDSCountQuery.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsRunningOnVDSCountQuery.java
deleted file mode 100644
index 54e81be..0000000
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsRunningOnVDSCountQuery.java
+++ /dev/null
@@ -1,16 +0,0 @@
-package org.ovirt.engine.core.bll;
-
-import org.ovirt.engine.core.common.queries.GetVmsRunningOnVDSCountParameters;
-import org.ovirt.engine.core.dal.dbbroker.DbFacade;
-
-public class GetVmsRunningOnVDSCountQuery<P extends
GetVmsRunningOnVDSCountParameters> extends QueriesCommandBase<P> {
- public GetVmsRunningOnVDSCountQuery(P parameters) {
- super(parameters);
- }
-
- @Override
- protected void executeQueryCommand() {
- getQueryReturnValue().setReturnValue(
-
DbFacade.getInstance().getVdsDynamicDao().get(getParameters().getId()).getvm_count());
- }
-}
diff --git
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsRunningOnVDSCountParameters.java
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsRunningOnVDSCountParameters.java
deleted file mode 100644
index c208b1d..0000000
---
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsRunningOnVDSCountParameters.java
+++ /dev/null
@@ -1,20 +0,0 @@
-package org.ovirt.engine.core.common.queries;
-
-import org.ovirt.engine.core.compat.*;
-
-public class GetVmsRunningOnVDSCountParameters extends VdcQueryParametersBase {
- private static final long serialVersionUID = 2045250638895753689L;
-
- public GetVmsRunningOnVDSCountParameters(Guid id) {
- _id = id;
- }
-
- private Guid _id;
-
- public Guid getId() {
- return _id;
- }
-
- public GetVmsRunningOnVDSCountParameters() {
- }
-}
diff --git
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
index 0f21bd5..3ad2075 100644
---
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
+++
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
@@ -8,7 +8,6 @@
GetVmByVmId(VdcQueryAuthType.User),
GetAllVms(VdcQueryAuthType.User),
GetVmsRunningOnVDS,
- GetVmsRunningOnVDSCount,
GetTopSizeVmsFromStorageDomain,
GetVmCustomProperties(VdcQueryAuthType.User),
GetVmConfigurationBySnapshot(VdcQueryAuthType.User),
--
To view, visit http://gerrit.ovirt.org/13288
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba10fb35ece3a9bc6ba9f5cbe43086d14e440262
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
