Allon Mureinik has uploaded a new change for review. Change subject: core: Remove GetVmsRunningOnVDSCount ......................................................................
core: Remove GetVmsRunningOnVDSCount GetVmsRunningOnVDSCountQuery is not used anywhere in the code, and thus should be removed. This patch removes the following: 1. The GetVmsRunningOnVDSCountQuery class. 2. The GetVmsRunningOnVDSCountParameters class only used by the aforementioned query class. 3. The GetVmsRunningOnVDSCount constant in VdcQueryType corresponding to the aforementioned query class. Change-Id: I519f1c4c74eb641b7251a830f5eb2317d868a9db Signed-off-by: Allon Mureinik <amure...@redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsRunningOnVDSQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsRunningOnVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 0 insertions(+), 38 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/89/13289/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsRunningOnVDSQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsRunningOnVDSQuery.java deleted file mode 100644 index 94ed0db..0000000 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsRunningOnVDSQuery.java +++ /dev/null @@ -1,17 +0,0 @@ -package org.ovirt.engine.core.bll; - -import org.ovirt.engine.core.common.queries.*; -import org.ovirt.engine.core.dal.dbbroker.*; - -public class GetVmsRunningOnVDSQuery<P extends GetVmsRunningOnVDSParameters> extends QueriesCommandBase<P> { - public GetVmsRunningOnVDSQuery(P parameters) { - super(parameters); - } - - @Override - protected void executeQueryCommand() { - getQueryReturnValue().setReturnValue( - DbFacade.getInstance().getVmDao().getAllRunningByVds(getParameters().getId())); - // ResourceManager.Instance.GetVmsRunningOnVDS(((GetVmsRunningOnVDSParameters)Parameters).Id); - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsRunningOnVDSParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsRunningOnVDSParameters.java deleted file mode 100644 index 16f5016..0000000 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsRunningOnVDSParameters.java +++ /dev/null @@ -1,20 +0,0 @@ -package org.ovirt.engine.core.common.queries; - -import org.ovirt.engine.core.compat.*; - -public class GetVmsRunningOnVDSParameters extends VdcQueryParametersBase { - private static final long serialVersionUID = 2940416694903953509L; - - public GetVmsRunningOnVDSParameters(Guid id) { - _id = id; - } - - private Guid _id; - - public Guid getId() { - return _id; - } - - public GetVmsRunningOnVDSParameters() { - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java index 3ad2075..12d9556 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java @@ -7,7 +7,6 @@ IsVmWithSameNameExist(VdcQueryAuthType.User), GetVmByVmId(VdcQueryAuthType.User), GetAllVms(VdcQueryAuthType.User), - GetVmsRunningOnVDS, GetTopSizeVmsFromStorageDomain, GetVmCustomProperties(VdcQueryAuthType.User), GetVmConfigurationBySnapshot(VdcQueryAuthType.User), -- To view, visit http://gerrit.ovirt.org/13289 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I519f1c4c74eb641b7251a830f5eb2317d868a9db Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches