Allon Mureinik has posted comments on this change.
Change subject: pki: cleanup: favor Charset.forName() over plain string
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
I'd extract Charset.forName("UTF-8") to a constant somewhere, while you're at it
--
To view, visit http://gerrit.ovirt.org/13192
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id61cad58356820a73683666235d328a72582486b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
