Alon Bar-Lev has posted comments on this change. Change subject: pki: cleanup: favor Charset.getName() over plain string ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EncryptionUtils.java Line 4: import java.io.FileInputStream; Line 5: import java.io.IOException; Line 6: import java.io.InputStream; Line 7: import java.math.BigInteger; Line 8: import java.nio.charset.Charset; Yes, I thought about that, then decided that I don't like the dependency of class level with usage... especially when implementation of the class is probably going to map anyway. Line 9: import java.security.GeneralSecurityException; Line 10: import java.security.InvalidKeyException; Line 11: import java.security.Key; Line 12: import java.security.KeyStore; .................................................... Commit Message Line 3: AuthorDate: 2013-03-20 00:24:35 +0200 Line 4: Commit: Alon Bar-Lev <alo...@redhat.com> Line 5: CommitDate: 2013-03-20 00:28:17 +0200 Line 6: Line 7: pki: cleanup: favor Charset.getName() over plain string Ops... Line 8: Line 9: Change-Id: Id61cad58356820a73683666235d328a72582486b -- To view, visit http://gerrit.ovirt.org/13192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id61cad58356820a73683666235d328a72582486b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
