Mike Kolesnik has posted comments on this change.
Change subject: engine: adding migration property to NetworkCluster
......................................................................
Patch Set 5: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java
Line 84: });
Line 85: if (net != null) {
Line 86: DbFacade.getInstance().getNetworkClusterDao().save(
Line 87: new
NetworkCluster(getParameters().getVdsGroup().getId(), net.getId(),
Line 88: NetworkStatus.OPERATIONAL, false,
true, false));
Shouldn't be true by default?
Line 89: }
Line 90: }
Line 91: setActionReturnValue(getVdsGroup().getId());
Line 92: setSucceeded(true);
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java
Line 19: import
org.ovirt.engine.core.dal.dbbroker.auditloghandling.CustomLogFields;
Line 20: import org.ovirt.engine.core.utils.NetworkUtils;
Line 21:
Line 22: @SuppressWarnings("serial")
Line 23: @CustomLogFields({ @CustomLogField("NetworkName") })
You should also handle UpdateNetworkOnClusterCommand
Line 24: public class AttachNetworkToVdsGroupCommand<T extends
AttachNetworkToVdsGroupParameter> extends
Line 25: VdsGroupCommandBase<T> {
Line 26:
Line 27: public AttachNetworkToVdsGroupCommand(T parameters) {
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkClusterDao.java
Line 89: *
Line 90: * @param clusterId
Line 91: * @param networkId
Line 92: */
Line 93: void setNetworkExclusivelyAsMigration(Guid clusterId, Guid
networkId);
I don't see that you used this method anywhere, I reckon it should be used when
adding/updating a network on cluster.
--
To view, visit http://gerrit.ovirt.org/12962
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I199b1f48b6d6096db2425c594e88455640dc626c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
