Moti Asayag has posted comments on this change.

Change subject: engine: adding migration property to NetworkCluster
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java
Line 121:             entity.setCluster(new NetworkCluster());
Line 122:             entity.getCluster().setDisplay((Boolean) 
rs.getObject("is_display"));
Line 123:             
entity.getCluster().setRequired(rs.getBoolean("required"));
Line 124:             
entity.getCluster().setStatus(NetworkStatus.forValue(rs.getInt("status")));
Line 125:             entity.getCluster().setMigration((Boolean) 
rs.getObject("migration"));
why shouldn't you use getBoolean ?
Line 126: 
Line 127:             return entity;
Line 128:         }
Line 129:     }


--
To view, visit http://gerrit.ovirt.org/12962
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I199b1f48b6d6096db2425c594e88455640dc626c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to