Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Updated parsing of the async tasks
......................................................................
Patch Set 3: No score
(1 inline comment)
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 840: )
Line 841:
Line 842: # We only want to return anything if there are really async tasks
records
Line 843: # Which means we have more than 1 line (headers)
Line 844: if runningTasks and len(runningTasks) > 1:
not sure about this >1. shouldn't it be > 0?
Line 845: tasks = '\n'.join(
Line 846: ['{task}\t{host}'.format(
Line 847: task=line['dc_name'],
Line 848: host=line['spm_host_name'],
--
To view, visit http://gerrit.ovirt.org/13131
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b1f24ef5e83cf09c01c3ebbb00375098ddc52c1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
