Moti Asayag has posted comments on this change. Change subject: engine: Fixing possible ConcurrentModificationException ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java Line 110: private final VDS _vds; Line 111: private final Map<Guid, VM> _vmDict; Line 112: private boolean processHardwareCapsNeeded; Line 113: private boolean refreshedCapabilities = false; Line 114: private static Map<Guid, Long> hostDownTimes = new ConcurrentHashMap<Guid, Long>(); Since this is a static variable, i assume it should leave for the entire run of the VdsManager. Wouldn't it make more sense to move it to VdsManager instead of maintaining the list statically here for all hosts ? That way we can also skip the need to sync unrelated events in the system. Line 115: private int runningVmsInTransition = 0; Line 116: Line 117: private static final Log log = LogFactory.getLog(VdsUpdateRunTimeInfo.class); Line 118: -- To view, visit http://gerrit.ovirt.org/13053 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifffc43fb28bdb6523d40fa7bbcc4673d5c29e786 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
