Michael Kublin has uploaded a new change for review.

Change subject: engine: Fixing possible ConcurrentModificationException
......................................................................

engine: Fixing possible ConcurrentModificationException

The following map can be accessed from different threads, that's why
access should be thread-safe, replaced to ConcurrentHashMap

Change-Id: Ifffc43fb28bdb6523d40fa7bbcc4673d5c29e786
Signed-off-by: Michael Kublin <mkub...@redhat.com>
---
M 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/53/13053/1

diff --git 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
index 67ef209..b867ced 100644
--- 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
+++ 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
@@ -11,6 +11,7 @@
 import java.util.Map;
 import java.util.Map.Entry;
 import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.atomic.AtomicBoolean;
 
 import org.apache.commons.lang.StringUtils;
@@ -110,7 +111,7 @@
     private final Map<Guid, VM> _vmDict;
     private boolean processHardwareCapsNeeded;
     private boolean refreshedCapabilities = false;
-    private static Map<Guid, Long> hostDownTimes = new HashMap<Guid, Long>();
+    private static Map<Guid, Long> hostDownTimes = new ConcurrentHashMap<Guid, 
Long>();
     private int runningVmsInTransition = 0;
 
     private static final Log log = 
LogFactory.getLog(VdsUpdateRunTimeInfo.class);


--
To view, visit http://gerrit.ovirt.org/13053
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifffc43fb28bdb6523d40fa7bbcc4673d5c29e786
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to