Vered Volansky has posted comments on this change.
Change subject: core: allow to perform hotplug/unplug/attach when vm is
suspended.
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java
Line 44: }
Line 45:
Line 46: private boolean checkCanPerformPlugUnPlugDisk() {
Line 47: boolean returnValue = true;
Line 48: if (getVm().getStatus().isUpOrPaused()) {
Weird, git grep didn't catch this one.
Line 49: setVdsId(getVm().getRunOnVds().getValue());
Line 50: returnValue =
Line 51: isHotPlugSupported() && isOsSupportingHotPlug()
Line 52: && isInterfaceSupportedForPlugUnPlug(disk);
--
To view, visit http://gerrit.ovirt.org/12986
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d950a1e7945e43ec5ee5ffa0f79c5f9536473a6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
