Allon Mureinik has posted comments on this change.
Change subject: core: allow to perform hotplug/unplug/attach when vm is
suspended.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java
Line 45: }
Line 46:
Line 47: private boolean checkCanPerformPlugUnPlugDisk() {
Line 48: boolean returnValue = true;
Line 49: if (getVm().getStatus() == VMStatus.Up || getVm().getStatus()
== VMStatus.Paused) {
Use VmStatus.isUpOrPaused(vm.getStatus()) instead.
Line 50: setVdsId(getVm().getRunOnVds().getValue());
Line 51: returnValue =
Line 52: isHotPlugSupported() && isOsSupportingHotPlug()
Line 53: && isInterfaceSupportedForPlugUnPlug(disk);
Line 72: }
Line 73:
Line 74: @Override
Line 75: protected void executeVmCommand() {
Line 76: if (getVm().getStatus() == VMStatus.Up || getVm().getStatus()
== VMStatus.Paused) {
Use VmStatus.isUpOrPaused(vm.getStatus()) instead.
Line 77: performPlugCommand(getPlugAction(), disk, oldVmDevice);
Line 78: }
Line 79:
Line 80: //Update boot order and isPlugged fields
....................................................
Commit Message
Line 5: CommitDate: 2013-03-12 18:29:39 +0200
Line 6:
Line 7: core: allow to perform hotplug/unplug/attach when vm is suspended.
Line 8:
Line 9: When vm is suspended there's no reason to not allow performing hot
s/vm/a VM/
s/to not/not to/
s/performing hot plug/hot plugging/ etc.
Line 10: plug/unplug and attach.
Line 11:
Line 12: Change-Id: I6d950a1e7945e43ec5ee5ffa0f79c5f9536473a6
Line 13: Bug-Url: https://bugzilla.redhat.com/918498
--
To view, visit http://gerrit.ovirt.org/12986
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d950a1e7945e43ec5ee5ffa0f79c5f9536473a6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
