Laszlo Hornyak has posted comments on this change.
Change subject: engine: unit test for VdsDeploy.getEngineSSHPublicKey
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
Line 217: if(aliaslist.length() != 0) {
Line 218: aliaslist.append(", ");
Line 219: }
Line 220: aliaslist.append(aliases.nextElement());
Line 221: }
if this condition is true, then the problem is already big enough, so I think a
low-performing but simple solution will be fine, like the one you recommended
but without the if
Line 222: log.info("aliases: " + aliaslist.toString());
Line 223: throw new KeyStoreException(
Line 224: String.format(
Line 225: "Failed to find certificate store '%1$s'
using alias '%2$s'",
--
To view, visit http://gerrit.ovirt.org/12719
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5397eece5eabf81755df93c381d9bb6934b237e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
